Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/896#issuecomment-121173161
> Wasn't the rationale to have a separate message for the heartbeat and the
accumulators to keep the heartbeat messages small? What do you think? In any
case, I agree that it makes sense to be able to configure this.
Initially, that was my proposal but I remember we discussed that we should
try to minimize the amount of messages and thus use the `Heartbeat` message. It
makes sense to be able to configure the snapshot transferal in multiples of the
hearbeat interval. I'd like to fix that in another pull
> I would add a unit test for the record reader/writer accumulator results.
I'll integrate that into the `AccumulatorLiveITCase`.
> There seems to be a 1:1 correspondence between the reporter and the
internal metrics. Is the idea to have multiple different reporters in the
future (for different types of metrics etc.) or is a long reporter sufficient?
For now, a long reporter is sufficient but if we discover that we need more
customizable reporters, we can easily change the reporter interface in the
future (it wouldn't be API breaking).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
