[
https://issues.apache.org/jira/browse/FLINK-8789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411188#comment-16411188
]
ASF GitHub Bot commented on FLINK-8789:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5753
[FLINK-8789] Throw IllegalStateException when calling Task#stopExecution on
not running Task
## What is the purpose of the change
Before we threw an UnsupportedOperationException when calling
Task#stopExecution on a Task
where we did not set the invokable yet. This can be a bit misleading and,
thus, this commit
throws an IllegalStateException with an respective message.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink FLINK-8789
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5753.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5753
----
commit 59fce96ba015d5373659ca9678e7fa403827f045
Author: Till Rohrmann <trohrmann@...>
Date: 2018-03-23T10:29:50Z
[FLINK-8789] Throw IllegalStateException when calling Task#stopExecution on
not running Task
Before we threw an UnsupportedOperationException when calling
Task#stopExecution on a Task
where we did not set the invokable yet. This can be a bit misleading and,
thus, this commit
throws an IllegalStateException with an respective message.
----
> StoppableFunctions sometimes not detected
> -----------------------------------------
>
> Key: FLINK-8789
> URL: https://issues.apache.org/jira/browse/FLINK-8789
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Till Rohrmann
> Priority: Blocker
> Fix For: 1.5.0
>
>
> While porting the {{TimestampITCase}} i got a strange exception in the logs
> when running {{testWatermarkPropagationNoFinalWatermarkOnStop}}:
> {code:java}
> Caused by: java.lang.UnsupportedOperationException: Stopping not supported by
> task Source: Custom Source (1/1) (87f44b422280be896bdf44766ebeb53e).
> at org.apache.flink.runtime.taskmanager.Task.stopExecution(Task.java:965)
> at
> org.apache.flink.runtime.taskexecutor.TaskExecutor.stopTask(TaskExecutor.java:549)
> ... 18 more{code}
> This source however implements the {{StoppableFunction}} interface.
> This happens also against a legacy cluster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
