GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5757
[FLINK-5411] [flip6] Fix JobLeaderIdService shut down in ResourceManager
## What is the purpose of the change
The JobLeaderIdService was formerly closed at two different locations. Once
in the
ResourceManager and once in the ResourceManagerRuntimeServices. Since the
JobLeaderIdService
is a RM specific component. It should also be closed in the scope of the RM.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink
fixJobLeaderIdServiceShutDown
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5757.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5757
----
commit 2bd3d6d1474b85dfaa341b829d7b0e9816bc9353
Author: Till Rohrmann <trohrmann@...>
Date: 2018-03-23T15:21:55Z
[FLINK-5411] [flip6] Fix JobLeaderIdService shut down in ResourceManager
The JobLeaderIdService was formerly closed at two different locations. Once
in the
ResourceManager and once in the ResourceManagerRuntimeServices. Since the
JobLeaderIdService
is a RM specific component. It should also be closed in the scope of the RM.
----
---
