[
https://issues.apache.org/jira/browse/FLINK-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413478#comment-16413478
]
ASF GitHub Bot commented on FLINK-8989:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5761#discussion_r176996077
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/elasticsearch/Elasticsearch1Example.java
---
@@ -37,20 +39,36 @@
import java.util.Map;
/**
- * This example shows how to use the Elasticsearch Sink. Before running it
you must ensure that
- * you have a cluster named "elasticsearch" running or change the cluster
name in the config map.
+ * End to end test for elasticsearch1.
+ *
+ * <p>This example shows how to use the Elasticsearch Sink from an user
endpoint. Before running it you
+ * must ensure that you have a cluster named "elasticsearch" running or
change the cluster name in the config map.
+ *
+ * <p>Example usage:
+ * --index my-index-person --type my-type-spiderman
*/
-@SuppressWarnings("serial")
-public class ElasticsearchSinkExample {
+public class Elasticsearch1Example {
public static void main(String[] args) throws Exception {
+ final ParameterTool parameterTool =
ParameterTool.fromArgs(args);
+
+ if (parameterTool.getNumberOfParameters() < 2) {
+ System.out.println("Missing parameters!\n" +
+ "Usage: --index <my-index-person>
--type <my-type-spiderman>");
--- End diff --
For a general example, I think we should keep the usage wordings more
general.
Therefore, "<my-index-person>" "<my-type-spiderman>" could just be "type",
"index".
> End-to-end test: ElasticSearch connector
> ----------------------------------------
>
> Key: FLINK-8989
> URL: https://issues.apache.org/jira/browse/FLINK-8989
> Project: Flink
> Issue Type: Sub-task
> Components: ElasticSearch Connector, Tests
> Reporter: Till Rohrmann
> Assignee: mingleizhang
> Priority: Major
>
> Similar to FLINK-8988 we should add a end-to-end test which tests the
> {{ElasticSearch}} connector. We should run against all three supported
> ElasticSearch versions: 1.x, 2.x and 5.x.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
