[
https://issues.apache.org/jira/browse/FLINK-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413829#comment-16413829
]
ASF GitHub Bot commented on FLINK-8940:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5764#discussion_r177083854
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -344,6 +363,42 @@ public void testJobRecovery() throws Exception {
assertThat(jobIds, contains(jobGraph.getJobID()));
}
+ /**
+ * Tests that we can dispose a savepoint.
+ */
+ @Test
+ public void testSavepointDisposal() throws Exception {
+ final DispatcherGateway dispatcherGateway =
dispatcher.getSelfGateway(DispatcherGateway.class);
+
+
dispatcherLeaderElectionService.isLeader(UUID.randomUUID()).get();
+
+ final URI externalPointer = createTestingSavepoint();
+ final Path savepointPath = Paths.get(externalPointer);
+
+ assertThat(Files.exists(savepointPath), is(true));
+
+ dispatcherGateway.disposeSavepoint(externalPointer.toString(),
TIMEOUT).get();
+
+ assertThat(Files.exists(savepointPath), is(false));
+ }
+
+ @Nonnull
+ public URI createTestingSavepoint() throws IOException,
URISyntaxException {
--- End diff --
make private?
> Implement JobMaster#disposeSavepoint
> ------------------------------------
>
> Key: FLINK-8940
> URL: https://issues.apache.org/jira/browse/FLINK-8940
> Project: Flink
> Issue Type: Improvement
> Components: JobManager, State Backends, Checkpointing
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Till Rohrmann
> Priority: Blocker
> Labels: flip-6
> Fix For: 1.5.0
>
>
> To support {{ClusterClient#disposeSavepoint}} we have to implement a
> {{disposeSavepoint}} method in the flip6 JobMaster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
