Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/905#issuecomment-121286738
Hi, thanks for the pull request.
I noticed that the `CollectionDataSets.getStringDataSet` data set does not
contain any duplicates. Therefore, it is not well suited to test the distinct
operator.
There also a few more tests for the Distinct operator that need to be
adapted:
- DistinctITCase.java
- DistinctOperatorTest.java
- DistinctOperatorTest.scala
The Unit tests (*Test) check if correct arguments are accepted and invalid
arguments are rejected. It would be nice, if you could try to do a distinct()
on a DataSet<YourObject>, where YourObject is not a Pojo but a generic type
which does not implement `Comparable`, i.e., it is not a Key type.
Thank you, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
