[ 
https://issues.apache.org/jira/browse/FLINK-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417082#comment-16417082
 ] 

ASF GitHub Bot commented on FLINK-8990:
---------------------------------------

GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/5779

    [FLINK-8990] [test] Extend Kafka end-to-end test to verify partition 
discovery

    ## What is the purpose of the change
    
    This PR is based on #5778.
    
    The changes further extends the Kafka end-to-end tests to cover verifying 
the partition discovery feature.
    
    ## Brief change log
    
    The whole test now does the following:
    - Start of with 1 partition for the test topic
    - Writes some messages, and then verify output
    - Add a new partition to the test topic
    - Verify that a new partition is really added to the topic
    - Writes some more messages
    - Verify that we really do have some messages in the new partition
    - Verify new output
    
    ## Verifying this change
    
    This PR is an extension to existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-8990

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5779.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5779
    
----
commit 7043de0257399b99f75dd8df7c8f009b5d51ce99
Author: Tzu-Li (Gordon) Tai <tzulitai@...>
Date:   2018-03-27T10:06:19Z

    [FLINK-8979] [test] Refactor Kafka-related common end-to-end test scripts

commit ecb0ce10d633e9310d86363ffa0bcea16504ebb5
Author: Tzu-Li (Gordon) Tai <tzulitai@...>
Date:   2018-03-27T13:14:35Z

    [FLINK-8979] [test] Include shuffles in Kafka end-to-end tests

commit 4f03f225011a8918ac0916050e6cac6814d293db
Author: Tzu-Li (Gordon) Tai <tzulitai@...>
Date:   2018-03-28T08:36:18Z

    [FLINK-8990] [test] Test partition discovery in Kafka end-to-end test

----


> End-to-end test: Dynamic Kafka partition discovery
> --------------------------------------------------
>
>                 Key: FLINK-8990
>                 URL: https://issues.apache.org/jira/browse/FLINK-8990
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Kafka Connector, Tests
>            Reporter: Till Rohrmann
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Major
>
> We should add an end-to-end test which verifies the dynamic partition 
> discovery of Flink's Kafka connector. We can simulate it by reading from a 
> Kafka topic to which we add partitions after the job started. By writing to 
> these new partitions it should be verifiable whether Flink noticed them by 
> checking the output for completeness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to