[
https://issues.apache.org/jira/browse/FLINK-9097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417287#comment-16417287
]
ASF GitHub Bot commented on FLINK-9097:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5774#discussion_r177726769
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
@@ -507,19 +539,21 @@ private TestingDispatcher(
jobManagerMetricGroup,
metricQueryServicePath,
archivedExecutionGraphStore,
- new
ExpectedJobIdJobManagerRunnerFactory(expectedJobId),
+ jobManagerRunnerFactory,
fatalErrorHandler,
null);
}
- @Override
- public CompletableFuture<Acknowledge> submitJob(final JobGraph
jobGraph, final Time timeout) {
- final CompletableFuture<Acknowledge> submitJobFuture =
super.submitJob(jobGraph, timeout);
-
- submitJobFuture.thenAccept(ignored ->
submitJobLatch.countDown());
- return submitJobFuture;
- }
+//
+// @Override
--- End diff --
delete commented code?
> Jobs can be dropped in HA when job submission fails
> ---------------------------------------------------
>
> Key: FLINK-9097
> URL: https://issues.apache.org/jira/browse/FLINK-9097
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Blocker
> Labels: flip-6
> Fix For: 1.5.0
>
>
> Jobs can be dropped in HA mode if the job submission step fails. In such a
> case, we should fail fatally to let the {{Dispatcher}} restart and retry to
> recover all jobs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
