Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5771#discussion_r177746665
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorLiveITCase.java
 ---
    @@ -167,6 +172,9 @@ private static void submitJobAndVerifyResults(JobGraph 
jobGraph) throws Exceptio
                        NotifyingMapper.shutdownLatch.trigger();
                } finally {
                        NotifyingMapper.shutdownLatch.trigger();
    +
    +                   // wait for the completion of the job
    +                   
clusterClient.requestJobResult(jobGraph.getJobID()).get();
    --- End diff --
    
    I would really prefer if we would stick to existing patterns for now, 
otherwise we end up with a barely-started interface in 1.5 that is used for a 
single test :/


---

Reply via email to