[
https://issues.apache.org/jira/browse/FLINK-6567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417332#comment-16417332
]
ASF GitHub Bot commented on FLINK-6567:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5782
[FLINK-6567] [tests] Harden ExecutionGraphMetricsTest
## What is the purpose of the change
The problem was that in some cases the currentRestartingTime would not
increase
because the iteration in the loop were too fast.
cc @zentol
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink
hardenExecutionGraphMetricsTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5782.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5782
----
commit 91b5db420f7e9079e9da364529fe125f157b9533
Author: Till Rohrmann <trohrmann@...>
Date: 2018-03-28T13:35:11Z
[FLINK-6567] [tests] Harden ExecutionGraphMetricsTest
The problem was that in some cases the currentRestartingTime would not
increase
because the iteration in the loop were too fast.
----
> ExecutionGraphMetricsTest fails on Windows CI
> ---------------------------------------------
>
> Key: FLINK-6567
> URL: https://issues.apache.org/jira/browse/FLINK-6567
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Till Rohrmann
> Priority: Blocker
> Labels: test-stability
> Fix For: 1.6.0
>
>
> The {{testExecutionGraphRestartTimeMetric}} fails every time i run it on
> AppVeyor. It also very rarely failed for me locally.
> The test fails at Line 235 if the RUNNING timestamp is equal to the
> RESTARTING timestamp, which may happen when combining a fast test with a low
> resolution clock.
> A simple fix would be to increase the timestamp between RUNNING and
> RESTARTING by adding a 50ms sleep timeout into the
> {{TestingRestartStrategy#canRestart()}} method, as this one is called before
> transitioning to the RESTARTING state.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
