[
https://issues.apache.org/jira/browse/FLINK-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626639#comment-14626639
]
ASF GitHub Bot commented on FLINK-2359:
---------------------------------------
GitHub user ggevay opened a pull request:
https://github.com/apache/flink/pull/911
[FLINK-2359] [java api] Add factory methods to the Java TupleX types
I added the creation of the factory method to the TupleGenerator.
I also fixed some inconsistencies between the generator and generated
files: it seems that some modifications were made to generated files without
modifying the generator. I incorporated these changes to the generator (see the
first three hunks in the generator) (except for some whitespace changes in the
first three modified files).
I randomly changed some constructor calls into using the new method for
testing and demonstration purposes (see the last two changed files).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ggevay/flink tupleCreate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/911.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #911
----
commit 295f663e28116ffce24e9178359810c0a00290b0
Author: Gabor Gevay <[email protected]>
Date: 2015-07-14T16:34:05Z
[FLINK-2359] [java api] Add factory methods to the Java TupleX types
----
> Add factory methods to the Java TupleX types
> --------------------------------------------
>
> Key: FLINK-2359
> URL: https://issues.apache.org/jira/browse/FLINK-2359
> Project: Flink
> Issue Type: Improvement
> Components: Java API
> Affects Versions: 0.10
> Reporter: Gabor Gevay
> Assignee: Gabor Gevay
> Priority: Minor
>
> The compiler doesn't infer generic type arguments from constructor arguments,
> which means that we have to call Tuple constructors like this:
> Tuple2<Integer, String> = new Tuple2<Integer, String>(5, "foo");
> I propose adding a factory method, which would provide the following
> alternative:
> Tuple2<Integer, String> = Tuple2.create(5, "foo");
> (Note that C++ and C# Tuples also have similar factory methods for the same
> reason.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
