[
https://issues.apache.org/jira/browse/FLINK-8966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417450#comment-16417450
]
ASF GitHub Bot commented on FLINK-8966:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5766#discussion_r177774638
--- Diff:
flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroExternalJarProgramITCase.java
---
@@ -44,49 +39,24 @@
private static final String TEST_DATA_FILE = "/testdata.avro";
- @Test
- public void testExternalProgram() {
-
- LocalFlinkMiniCluster testMiniCluster = null;
+ private static final MiniClusterResource miniClusterResource = new
MiniClusterResource(
+ new MiniClusterResource.MiniClusterResourceConfiguration(
+ new Configuration(),
+ 1,
+ 4));
+ @Test
+ public void testExternalProgram() throws Exception {
+ miniClusterResource.setJarFiles(Collections.singleton(new
Path(JAR_FILE)));
--- End diff --
I think instead of passing the `JAR_FILE` to the `MiniClusterResource` we
should set the `TestEnvironment` with the correct jar files settings explicitly
in this test.
> Port AvroExternalJarProgramITCase to flip6
> ------------------------------------------
>
> Key: FLINK-8966
> URL: https://issues.apache.org/jira/browse/FLINK-8966
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.5.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
