Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5730#discussion_r177798624
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java
 ---
    @@ -80,42 +95,38 @@ public void testJobRetrieval() throws Exception {
     
                final JobGraph jobGraph = new JobGraph(jobID, "testjob", 
imalock);
     
    -           final ClusterClient<StandaloneClusterId> client = new 
StandaloneClusterClient(cluster.configuration(), 
cluster.highAvailabilityServices(), true);
    -
                // acquire the lock to make sure that the job cannot complete 
until the job client
                // has been attached in resumingThread
                lock.acquire();
    --- End diff --
    
    But there is still a difference between asking for the result when the job 
is finished (where you get it right away) versus when the job running (where 
you have to poll).
    
    The test should cover both.


---

Reply via email to