GitHub user sihuazhou opened a pull request:

    https://github.com/apache/flink/pull/5783

    [FLINK-9081][test] Harden ResourceManagerTaskExecutorTest

    ## What is the purpose of the change
    
    Currently, `heartbeatTimeout` is 5, it's too small, so the 
`ResourceManagerTaskExecutorTest.testRegisterTaskExecutor()` could be unstable 
on travis easily, this PR set `heartbeatTimeout` to 1000 (the same as the other 
unit tests that use the `HeartbeatServices`).
    
    ## Brief change log
    
    - set `heartbeat Timeout` to 1000 in `ResourceManagerTaskExecutorTest` and 
`ResourceManagerJobMasterTest`
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sihuazhou/flink FLINK_9081

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5783.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5783
    
----
commit 8f0c6add624ce826cdeaadea8e7501c798a576f2
Author: sihuazhou <summerleafs@...>
Date:   2018-03-28T16:35:24Z

    set heartbeatTimeout=1000 in ResourceManagerJobMasterTest and 
ResourceManagerTaskExecutorTest.

----


---

Reply via email to