Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5756#discussion_r178029070
  
    --- Diff: 
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
 ---
    @@ -93,6 +93,10 @@ private MiniClusterResource(
                this.enableClusterClient = enableClusterClient;
        }
     
    +   public MiniClusterType getMiniClusterType() {
    --- End diff --
    
    I would prefer to keep the enum. Name `isLegacyDeployment` would deprecate 
faster then the enum type. Also enums are more flexible (adding/removing more 
values in the future).
    
    Regardless there is no big advantage of one over the other, so if you want, 
I can change it either way.


---

Reply via email to