[
https://issues.apache.org/jira/browse/FLINK-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423431#comment-16423431
]
ASF GitHub Bot commented on FLINK-9087:
---------------------------------------
GitHub user trionesadam opened a pull request:
https://github.com/apache/flink/pull/5802
[FLINK-9087] [runtime] close the BufferConsumer in RecordWriter.broad…
## What is the purpose of the change
BufferConsumer is Closeable, we'd better close it at last,
## Brief change log
RecordWriter.broadcastEvent() is called in StreamTask., RecordWriterOutput
,IterationIntermediateTask and IterationHeadTaskbroadcastEvent, also notice
that no one make use of the BufferConsumer returned by broadcastEvent(), so i
think the better way to close the return value in RecordWriter. change the
method signature from BufferConsumer to void， and close the BufferConsumer in
the end.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trionesadam/flink
FLINK-9087-close-broadcastEvent
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5802.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5802
----
commit a8efee487dd2fcd3bc95732c9676f5ed71d19bf0
Author: triones.deng <triones.deng@...>
Date: 2018-04-03T02:28:52Z
[FLINK-9087] [runtime] close the BufferConsumer in
RecordWriter.broadcastEvent()
----
> Return value of broadcastEvent should be closed in
> StreamTask#performCheckpoint
> -------------------------------------------------------------------------------
>
> Key: FLINK-9087
> URL: https://issues.apache.org/jira/browse/FLINK-9087
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: mingleizhang
> Priority: Minor
>
> {code}
> for (StreamRecordWriter<SerializationDelegate<StreamRecord<OUT>>>
> streamRecordWriter : streamRecordWriters) {
> try {
> streamRecordWriter.broadcastEvent(message);
> {code}
> The BufferConsumer returned by broadcastEvent() should be closed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
