Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5669#discussion_r178769136
  
    --- Diff: 
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
 ---
    @@ -1063,23 +1078,27 @@ public void runCancelingOnEmptyInputTest() throws 
Exception {
     
                final AtomicReference<Throwable> error = new 
AtomicReference<>();
     
    +           final StreamExecutionEnvironment env = 
StreamExecutionEnvironment.getExecutionEnvironment();
    --- End diff --
    
    That would go further than porting the test; I'd rather not do that in this 
PR.
    



---

Reply via email to