Github user zhangminglei commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5808#discussion_r179060468
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java 
---
    @@ -104,40 +104,40 @@
                                " global ssl flag " + 
SecurityOptions.SSL_ENABLED.key() + " is set to true");
     
        /**
    -    * The initial registration pause between two consecutive registration 
attempts. The pause
    -    * is doubled for each new registration attempt until it reaches the 
maximum registration pause.
    +    * The initial registration backoff between two consecutive 
registration attempts. The backoff
    +    * is doubled for each new registration attempt until it reaches the 
maximum registration backoff.
         */
    -   public static final ConfigOption<String> INITIAL_REGISTRATION_PAUSE =
    -           key("taskmanager.initial-registration-pause")
    +   public static final ConfigOption<String> INITIAL_REGISTRATION_BACKOFF =
    +           key("taskmanager.registration.initial-backoff")
    --- End diff --
    
    I think there already has deprecated key 
```"taskmanager.initial-registration-pause"``` in the 
```ConfigConstants.java``` file. Below:
    
    ```
    /**
     * The initial registration pause between two consecutive registration 
attempts. The pause
     * is doubled for each new registration attempt until it reaches the 
maximum registration pause.
     *
     * @deprecated use {@link TaskManagerOptions#INITIAL_REGISTRATION_BACKOFF} 
instead
     */
    @Deprecated
    public static final String TASK_MANAGER_INITIAL_REGISTRATION_PAUSE = 
"taskmanager.initial-registration-pause";
    ```
    Or, I am guessing what you mean is that I should change the value  
```taskmanager.initial-registration-pause``` to 
```taskmanager.registration.initial-backoff``` in ```ConfigConstants.java``` 
file. But you said ((nor should we change the value)) before. So, Hmm. Am I 
missing something ?


---

Reply via email to