[ https://issues.apache.org/jira/browse/FLINK-8620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425178#comment-16425178 ]
ASF GitHub Bot commented on FLINK-8620: --------------------------------------- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5580#discussion_r179056758 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java --- @@ -262,106 +216,120 @@ private static Thread createShutdownHook(final FileCache cache, final Logger log ); } + public void releaseJob(JobID jobId, ExecutionAttemptID executionId) { + checkNotNull(jobId); + + synchronized (lock) { + Set<ExecutionAttemptID> jobRefCounter = jobRefHolders.get(jobId); + + if (jobRefCounter == null || jobRefCounter.isEmpty()) { + LOG.warn("improper use of releaseJob() without a matching number of createTmpFiles() calls for jobId " + jobId); + return; + } + + jobRefCounter.remove(executionId); --- End diff -- shouldn't we also remove the entries? Otherwise the `entries` map will continue to grow until either the TM shuts down or the or crashes with an OOM error. > Enable shipping custom artifacts to BlobStore and accessing them through > DistributedCache > ----------------------------------------------------------------------------------------- > > Key: FLINK-8620 > URL: https://issues.apache.org/jira/browse/FLINK-8620 > Project: Flink > Issue Type: New Feature > Reporter: Dawid Wysakowicz > Assignee: Dawid Wysakowicz > Priority: Major > > We should be able to distribute custom files to taskmanagers. To do that we > can store those files in BlobStore and later on access them in TaskManagers > through DistributedCache. -- This message was sent by Atlassian JIRA (v7.6.3#76005)