Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5580#discussion_r179079963
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/filecache/FileCacheReadsFromBlobTest.java
 ---
    @@ -33,16 +38,16 @@
     
     import java.io.File;
     import java.io.IOException;
    +import java.nio.charset.StandardCharsets;
     import java.util.concurrent.Future;
     
    -import static org.junit.Assert.assertFalse;
    +import static org.junit.Assert.assertEquals;
     import static org.junit.Assert.assertTrue;
    -import static org.junit.Assert.fail;
     
     /**
    - * Test delete process of {@link FileCache}. The local cache file should 
not be deleted why another task comes in 5 seconds.
    + * Tests that {@link FileCache} can read files from {@link BlobServer}.
      */
    -public class FileCacheDeleteValidationTest {
    +public class FileCacheReadsFromBlobTest {
    --- End diff --
    
    it does, it is `FileCache` responsibility to unzip.


---

Reply via email to