[
https://issues.apache.org/jira/browse/FLINK-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425945#comment-16425945
]
ASF GitHub Bot commented on FLINK-9136:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5817
[FLINK-9136][tests] Remove StreamingProgramTestBase
Builds on #5816.
## What is the purpose of the change
This PR removes the `StreamingProgramTestBase` class.
The class discourages reusing cluster resources as every test must be setup
in a new class. Additionally, it appears to mimic to jUnits `@Before/@After`
life-cycle, but actually doesn't as the `postSubmit` method is not called not
called if `testPogram` fails with an exception. This can lead to resource
leaks, like for example in the `ContinuousFileProcessingITCase`.
Existing usages were ported to the `AbstractTestBase`.
If a tests was using preSubmit to setup data and postSubmit to verify the
result, then the methods were merged into a single method.
Otherwise, `preSubmit` implementations were annotated with `@Before`,
`postSubmit` implementations with `@After`, and `testProgram` implementations
with `@Test`.
Additionally the visibility of these methods was set to `public`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9136
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5817.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5817
----
commit b3a31933432f4ad4eaeffd28ced16a570910986d
Author: zentol <chesnay@...>
Date: 2018-04-04T17:49:35Z
[FLINK-9137][tests] Merge TopSpeedWindowingExampleITCase into
StreamingExamplesITCase
commit a56c6f969a5fb03260fa0d2705356f0d01badb18
Author: zentol <chesnay@...>
Date: 2018-04-04T17:22:53Z
[FLINK-9136][tests] Remove StreamingProgramTestBase
----
> Remove StreamingProgramTestBase
> -------------------------------
>
> Key: FLINK-9136
> URL: https://issues.apache.org/jira/browse/FLINK-9136
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Minor
>
> The {{StreamingProgramTestBase}} should be removed. We can move all existing
> tests to the {{AbstractTestBase}} with junit annotations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
