[ 
https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434117#comment-16434117
 ] 

ASF GitHub Bot commented on FLINK-9008:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5823#discussion_r180810121
  
    --- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh ---
    @@ -0,0 +1,117 @@
    +#!/usr/bin/env bash
    
+################################################################################
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    
+################################################################################
    +
    +# End to end test for quick starts test.
    +
    +CURRENT_DIR=$(cd "$( dirname "$0"  )" && pwd )
    +
    +cd $CURRENT_DIR
    +
    +mvn archetype:generate                             \
    +    -DarchetypeGroupId=org.apache.flink            \
    +    -DarchetypeArtifactId=flink-quickstart-java    \
    +    -DarchetypeVersion=1.4.2                       \
    +    -DgroupId=org.apache.flink.quickstart          \
    +    -DartifactId=flink-java-project                \
    +    -Dversion=0.1                                  \
    +    -Dpackage=org.apache.flink.quickstart          \
    +    -DinteractiveMode=false
    +
    +cd flink-java-project
    +
    +cp $CURRENT_DIR/test-class/ElasticsearchStreamingJob.java 
$CURRENT_DIR/flink-java-project/src/main/java/org/apache/flink/quickstart/
    +
    +sed -i -e '80i\
    --- End diff --
    
    This is quite brittle. What you have to realize is that any change to the 
original pom may now break this test, even if it is just reorganizing the pom.
    
    A better alternative would be to search for the `<dependencies>` tag and 
insert the dependency after that.


> End-to-end test: Quickstarts
> ----------------------------
>
>                 Key: FLINK-9008
>                 URL: https://issues.apache.org/jira/browse/FLINK-9008
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Quickstarts, Tests
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: mingleizhang
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> We could add an end-to-end test which verifies Flink's quickstarts. It should 
> do the following:
> # create a new Flink project using the quickstarts archetype 
> # add a new Flink dependency to the {{pom.xml}} (e.g. Flink connector or 
> library) 
> # run {{mvn clean package -Pbuild-jar}}
> # verify that no core dependencies are contained in the jar file
> # Run the program



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to