Github user ggevay commented on the pull request:

    https://github.com/apache/flink/pull/911#issuecomment-121633275
  
    @fhueske:
    I included the reformatting changes because the generator is making them. 
This is happening because some modifications were made directly to some 
generated codes in the past, which made them inconsistent with the generator. 
But I guess the goal should be that the generator program would have no effect 
on the master. One way to achieve this is to commit the changes the generator 
makes, and the other way would be to change the generator to follow the 
reformatting. Do you think that I should change the PR to the latter with 
respect to the reformattings as well? (I already did the latter with respect to 
some real changes, see my opening comment.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to