[
https://issues.apache.org/jira/browse/FLINK-8955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437679#comment-16437679
]
ASF GitHub Bot commented on FLINK-8955:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5780#discussion_r181466728
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -117,6 +138,7 @@ public TestEnvironment getTestEnvironment() {
@Override
public void before() throws Exception {
+ miniClusterResourceConfiguration =
Preconditions.checkNotNull(miniClusterResourceConfigurationSupplier.get());
--- End diff --
I think we are mixing concerns by letting the `MiniClusterResource` change
its behaviour across multiple tests. I think we should not pass in a
configuration supplier which can lazily instantiate a configuration. Instead if
you need a different `MiniClusterResource` per test, then the test should
instantiate the respective `MiniClusterResource` with the proper configuration.
> Port ClassLoaderITCase to flip6
> -------------------------------
>
> Key: FLINK-8955
> URL: https://issues.apache.org/jira/browse/FLINK-8955
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.5.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
