GitHub user yuqi1129 opened a pull request:

    https://github.com/apache/flink/pull/5846

    [FLINK-9143] [client] Restart strategy defined in flink-conf.yaml is ignored

    
    ## What is the purpose of the change
    
    This change is to fix the bug that if restart strategy was not specifically 
set in user code, flink will not use default strategy set in flink-conf.yaml in 
flip6 mode. 
    ## Brief change log
    
      - In `ClusterClient.getJobGraph`, if no strategy was set in user code, we 
set strategy strategy just as flink-conf.yaml do 
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - Add `ClusterClientTest.testgetJobGraph` 
     -  Add `FailureRateRestartStrategyTest.testFailureRateRestartStrategyConf` 
and `FixedDelayRestartStrategyTest.testFixedRestartStrategyConf`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yuqi1129/flink confproblem

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5846.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5846
    
----
commit 7c2a8045a310e2942f4fbec3b4a2696b73fae3af
Author: hzyuqi1 <hzyuqi1@...>
Date:   2018-04-14T05:45:06Z

    [FLINK-9143] [client] Restart strategy defined in flink-conf.yaml is ignored
    
    This closes #9143.

commit df23fbe809c2cbd025a923cd8607ec852d40b4ae
Author: hzyuqi1 <hzyuqi1@...>
Date:   2018-04-14T05:46:21Z

    Merge branch 'master' of https://github.com/apache/flink into confproblem

----


---

Reply via email to