Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5849#discussion_r181688711
  
    --- Diff: flink-end-to-end-tests/test-scripts/test_rest_api.sh ---
    @@ -0,0 +1,44 @@
    +#!/usr/bin/env bash
    
+################################################################################
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    
+################################################################################
    +
    +source "$(dirname "$0")"/common.sh
    +
    
+TEST_JAR_JAR=$TEST_INFRA_DIR/../../flink-end-to-end-tests/flink-rest-api-test/target/PeriodicStreamingJob.jar
    
+TEST_PROGRAM_JAR=$TEST_INFRA_DIR/../../flink-end-to-end-tests/flink-rest-api-test/target/RestApiTestSuite.jar
    +
    +echo "Run Rest-Api-Test Program"
    +
    +start_cluster
    +$FLINK_DIR/bin/taskmanager.sh start
    +$FLINK_DIR/bin/taskmanager.sh start
    +$FLINK_DIR/bin/taskmanager.sh start
    +
    +# Start periodic streaming job to test against
    +$FLINK_DIR/bin/flink run -p 4 $TEST_JAR_JAR -outputPath 
file://${TEST_DATA_DIR}/out/result &
    +
    +# Wait for the job to come up
    +sleep 5s
    --- End diff --
    
    we can handle this more efficiently in the java program by polling the REST 
API


---

Reply via email to