ASF GitHub Bot commented on FLINK-2435:

Github user fhueske commented on the issue:

    Thanks for opening this PR @DmitryKober!
    I had a quick look over the changes and there are a few things that can be 
fixed such as:
    - reverting all unnecessary changes such as changing import order or white 
space changes
    - merging all commits into a single commit
    - check if the changes to `TupleTypeInfo` are required
    - check if we can add this feature without adding a dependency to 
    You can update the PR by force pushing into your Github branch.
    Thanks, Fabian

> Add support for custom CSV field parsers
> ----------------------------------------
>                 Key: FLINK-2435
>                 URL: https://issues.apache.org/jira/browse/FLINK-2435
>             Project: Flink
>          Issue Type: New Feature
>          Components: DataSet API
>    Affects Versions: 0.10.0
>            Reporter: Fabian Hueske
>            Assignee: Dmitrii Kober
>            Priority: Minor
>             Fix For: 1.0.0
> The {{CSVInputFormats}} have only {{FieldParsers}} for Java's primitive types 
> (byte, short, int, long, float, double, boolean, String).
> It would be good to add support for CSV field parsers for custom data types 
> which can be registered in a {{CSVReader}}. 
> We could offer two interfaces for field parsers.
> 1. The regular low-level {{FieldParser}} which operates on a byte array and 
> offsets.
> 2. A {{StringFieldParser}} which operates on a String that has been extracted 
> by a {{StringParser}} before. This interface will be easier to implement but 
> less efficient.

This message was sent by Atlassian JIRA

Reply via email to