[ 
https://issues.apache.org/jira/browse/FLINK-9180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439468#comment-16439468
 ] 

ASF GitHub Bot commented on FLINK-9180:
---------------------------------------

GitHub user lamber-ken opened a pull request:

    https://github.com/apache/flink/pull/5857

    [FLINK-9180][METRICS] add prometheus pushgateway reporter

    ## What is the purpose of the change
    This pull request makes flink system can send metrics to prometheus via 
pushgateway. when using `yarn-cluster` model, it's useful.
    
    ## Brief change log
    
      - Add prometheus pushgateway repoter
      - Restructure the code of the promethues reporter part
    
    ## Verifying this change
    
    This change is already covered by existing tests. [prometheus 
test](https://github.com/apache/flink/tree/master/flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus)
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (JavaDocs)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lamber-ken/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5857.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5857
    
----
commit a3503a5d08e4d02d6cf38d656e2697d3b1197cf1
Author: lamber-ken <!@...>
Date:   2018-04-16T13:49:56Z

    add prometheus pushgateway reporter

----


> Remove REST_ prefix from rest options
> -------------------------------------
>
>                 Key: FLINK-9180
>                 URL: https://issues.apache.org/jira/browse/FLINK-9180
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration, REST
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: mingleizhang
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> Several fields in the {{RestOptions}} class have a {{REST_}} prefix. So far 
> we went with the convention that we do not have such prefixes if it already 
> contained in the class name, hence we should remove it from the field names.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to