[
https://issues.apache.org/jira/browse/FLINK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439561#comment-16439561
]
Advertising
ASF GitHub Bot commented on FLINK-8703:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5665#discussion_r181776571
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebFrontendITCase.java
---
@@ -217,12 +231,12 @@ public void getTaskManagerLogAndStdoutFiles() {
@Test
public void getConfiguration() {
try {
- String config =
TestBaseUtils.getFromHTTP("http://localhost:"; + port + "/jobmanager/config");
+ String config =
TestBaseUtils.getFromHTTP("http://localhost:"; + CLUSTER.getWebUIPort() +
"/jobmanager/config");
Map<String, String> conf =
WebMonitorUtils.fromKeyValueJsonArray(config);
assertEquals(
-
cluster.configuration().getString("taskmanager.numberOfTaskSlots", null),
-
conf.get(ConfigConstants.TASK_MANAGER_NUM_TASK_SLOTS));
+
CLUSTER_CONFIGURATION.getString(ConfigConstants.LOCAL_START_WEBSERVER, null),
--- End diff --
I wanted an option for which the configured value is different from the
default. The default for `numberOfTaskSlots` is one, so the test would've
passed even if the handler returned a vanilla configuration.
> Migrate tests from LocalFlinkMiniCluster to MiniClusterResource
> ---------------------------------------------------------------
>
> Key: FLINK-8703
> URL: https://issues.apache.org/jira/browse/FLINK-8703
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Reporter: Aljoscha Krettek
> Assignee: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.5.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
