Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5676#discussion_r182048477
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/TaskInfo.java ---
    @@ -107,4 +131,12 @@ public int getAttemptNumber() {
        public String getTaskNameWithSubtasks() {
                return this.taskNameWithSubtasks;
        }
    +
    +   /**
    +    * Returns the allocation id for where this task is executed.
    +    * @return the allocation id for where this task is executed.
    +    */
    +   public String getAllocationID() {
    --- End diff --
    
    @sihuazhou that approach would not allow us to test that the scheduling 
works proper when having more than one slot per TM, which is a useful thing to 
test for. Furthermore, this also silently makes the assumption that there is a 
connection between allocation id and PID, but the test might want to also 
validate that this is actually true.


---

Reply via email to