[
https://issues.apache.org/jira/browse/FLINK-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442326#comment-16442326
]
ASF GitHub Bot commented on FLINK-8946:
---------------------------------------
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5869
[FLINK-8946] TaskManager stop sending metrics after JobManager failover
## What is the purpose of the change
*This pull request fixed taskManager stop sending metrics after JobManager
failover*
## Brief change log
- *Initialize `TaskManagerMetricGroup`'s instance when invoking
`handleJobManagerLeaderAddress`*
- *Close `TaskManagerMetricGroup` when invoking
`handleJobManagerDisconnect`*
## Verifying this change
This change is already covered by existing tests, such as
*TaskManagerStartupTest*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-8946
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5869.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5869
----
commit 340a8fc30137bea7b6433263f7ea968849e00cdf
Author: yanghua <yanghua1127@...>
Date: 2018-04-18T11:07:30Z
[FLINK-8946] TaskManager stop sending metrics after JobManager failover
----
> TaskManager stop sending metrics after JobManager failover
> ----------------------------------------------------------
>
> Key: FLINK-8946
> URL: https://issues.apache.org/jira/browse/FLINK-8946
> Project: Flink
> Issue Type: Bug
> Components: Metrics, TaskManager
> Affects Versions: 1.4.2
> Reporter: Truong Duc Kien
> Assignee: vinoyang
> Priority: Critical
> Fix For: 1.5.0
>
>
> Running in Yarn-standalone mode, when the Job Manager performs a failover,
> all TaskManager that are inherited from the previous JobManager will not send
> metrics to the new JobManager and other registered metric reporters.
>
> A cursory glance reveal that these line of code might be the cause
> [https://github.com/apache/flink/blob/a3478fdfa0f792104123fefbd9bdf01f5029de51/flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala#L1082-L1086]
> Perhap the TaskManager close its metrics group when disassociating
> JobManager, but not creating a new one on fail-over association ?
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
