[
https://issues.apache.org/jira/browse/FLINK-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629761#comment-14629761
]
ASF GitHub Bot commented on FLINK-2368:
---------------------------------------
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/918#discussion_r34788837
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/SVM.scala
---
@@ -382,7 +402,11 @@ object SVM{
// calculate the new weight vector by adding the weight vector
updates to the weight
// vector value
- weights.union(weightedDeltaWs).reduce { _ + _ }
+ val newWeights = weights.union(weightedDeltaWs).reduce { _ + _
}
+ if(convergenceDefined){
+ converger.get.construct(input,weights,newWeights)
--- End diff --
@tillrohrmann , could you take a look here? I am unable to work out the
problem here.
> Add a convergence criteria
> --------------------------
>
> Key: FLINK-2368
> URL: https://issues.apache.org/jira/browse/FLINK-2368
> Project: Flink
> Issue Type: Bug
> Components: Machine Learning Library
> Reporter: Sachin Goel
> Assignee: Sachin Goel
>
> Add a convergence criteria for the Machine Learning library. If an algorithm
> is iteration based, it should have a setConvergenceCritieria function which
> will check for convergence at the end of every iteration based on the user
> defined criteria.
> Algorithm writer will provide the user will the training data set, solution
> before an iteration and solution after the iteration and user will have to
> return an empty data set in case the training needs to be terminated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
