[
https://issues.apache.org/jira/browse/FLINK-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442624#comment-16442624
]
ASF GitHub Bot commented on FLINK-9206:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5872#discussion_r182455202
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -1214,7 +1216,7 @@ public void run() {
triggerCheckpoint(System.currentTimeMillis(),
true);
}
catch (Exception e) {
- LOG.error("Exception while triggering
checkpoint.", e);
+ LOG.error("Exception while triggering
checkpoint for job " + job + ".", e);
--- End diff --
I was also thinking about this but decided to keep the style of each
individual message (ok, there was no previous style here). I could change all
changed lines to adhere the string formats instead of string concatenation if
you think, that's better
> CheckpointCoordinator log messages do not contain the job ID
> ------------------------------------------------------------
>
> Key: FLINK-9206
> URL: https://issues.apache.org/jira/browse/FLINK-9206
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Affects Versions: 1.4.0, 1.5.0, 1.4.1, 1.4.2, 1.6.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Major
> Fix For: 1.5.0, 1.4.3
>
>
> The {{CheckpointCoordinator}} exists per job but several of its log messages
> do not contain the job ID and thus if multiple jobs exist, we could not track
> which log message belongs to which job.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)