Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5555#discussion_r182478446
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -93,6 +97,8 @@ class AggregationCodeGenerator(
aggregates: Array[AggregateFunction[_ <: Any, _ <: Any]],
aggFields: Array[Array[Int]],
aggMapping: Array[Int],
+ distinctAggs: Array[Seq[DataViewSpec[_]]],
--- End diff --
I would make this an `Array[Boolean]` and rename to `isDistinctAgg`. We can
build the `MapViewSpec`s in the method. We have all the information for that in
the other parameters.
---
