[
https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444230#comment-16444230
]
ASF GitHub Bot commented on FLINK-8689:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5555#discussion_r182773359
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -417,13 +530,26 @@ class AggregationCodeGenerator(
.stripMargin
val create: String = {
for (i <- aggs.indices) yield {
- j"""
- | ${accTypes(i)} acc$i = (${accTypes(i)})
${aggs(i)}.createAccumulator();
- | ${genDataViewFieldSetter(s"acc$i", i)}
- | accs.setField(
- | $i,
- | acc$i);"""
- .stripMargin
+ if (isDistinctAggs(i)) {
+ j"""
+ | ${accTypes(i)} acc$i = (${accTypes(i)})
${aggs(i)}.createAccumulator();
+ | $distinctAccType distinctAcc$i = ($distinctAccType)
new org.apache.flink.table.
+ | functions.aggfunctions.DistinctAccumulator(acc$i);
+ | ${genDistinctDataViewFieldSetter(s"distinctAcc$i", i)}
--- End diff --
I think this and the `genAccDataViewFieldSetter` call (both from here and
the non-distinct case) can be removed.
> Add runtime support of distinct filter using MapView
> -----------------------------------------------------
>
> Key: FLINK-8689
> URL: https://issues.apache.org/jira/browse/FLINK-8689
> Project: Flink
> Issue Type: Sub-task
> Reporter: Rong Rong
> Assignee: Rong Rong
> Priority: Major
>
> This ticket should cover distinct aggregate function support to codegen for
> *AggregateCall*, where *isDistinct* fields is set to true.
> This can be verified using the following SQL, which is not currently
> producing correct results.
> {code:java}
> SELECT
> a,
> SUM(b) OVER (PARTITION BY a ORDER BY proctime ROWS BETWEEN 5 PRECEDING AND
> CURRENT ROW)
> FROM
> MyTable{code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
