Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5881#discussion_r183243246
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ---
@@ -388,4 +390,108 @@ public void testStopWorker() throws Exception {
assertTrue(resourceManager.getNumberOfRegisteredTaskManagers().get() == 0);
}};
}
+
+ /**
+ * Tests the case that containers are killed before registering with
ResourceManager successfully.
+ */
+ @Test
+ public void testKillContainerBeforeTMRegisterSuccessfully() throws
Exception {
--- End diff --
I would drop this test because it is too complicated, uses internal hadoop
APIs, and heavily relies on mocking. What do you think?
---
