[jira] [Commented] (FLINK-9234) Commons Logging is missing from shaded Flink Table library

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447809#comment-16447809
 ] 

ASF GitHub Bot commented on FLINK-9234:
---------------------------------------

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/5897

    [FLINK-9234] [table] Fix missing dependencies for external catalogs

    ## What is the purpose of the change
    
    This PR adds the required dependencies `commons-logging` (via `slf4j`) and 
`commons-collections` to `flink-table`. They are required for the deprecated 
external catalog discovery.
    
    ## Brief change log
    
    Modified `pom.xml`.
    
    
    ## Verifying this change
    
    Manually verified.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): yes
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-9234

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5897.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5897
    
----
commit 1c4a6695496f021a6be7bc58090bdc64a97aa87e
Author: Timo Walther <twalthr@...>
Date:   2018-04-23T09:04:51Z

    [FLINK-9234] [table] Fix missing dependencies for external catalogs

----


> Commons Logging is missing from shaded Flink Table library
> ----------------------------------------------------------
>
>                 Key: FLINK-9234
>                 URL: https://issues.apache.org/jira/browse/FLINK-9234
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API &amp; SQL
>    Affects Versions: 1.4.2
>         Environment: jdk1.8.0_172
> flink 1.4.2
> Mac High Sierra
>            Reporter: Eron Wright 
>            Assignee: Timo Walther
>            Priority: Blocker
>         Attachments: repro.scala
>
>
> The flink-table shaded library seems to be missing some classes from 
> {{org.apache.commons.logging}} that are required by 
> {{org.apache.commons.configuration}}.  Ran into the problem while using the 
> external catalog support, on Flink 1.4.2.
> See attached a repro, which produces:
> {code}
> Exception in thread "main" java.lang.NoClassDefFoundError: 
> org/apache/flink/table/shaded/org/apache/commons/logging/Log
>       at 
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.parseScanPackagesFromConfigFile(ExternalTableSourceUtil.scala:153)
>       at 
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.<init>(ExternalTableSourceUtil.scala:55)
>       at 
> org.apache.flink.table.catalog.ExternalTableSourceUtil$.<clinit>(ExternalTableSourceUtil.scala)
>       at 
> org.apache.flink.table.catalog.ExternalCatalogSchema.getTable(ExternalCatalogSchema.scala:78)
>       at 
> org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
>       at 
> org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:256)
>       at 
> org.apache.calcite.jdbc.CalciteSchema$SchemaPlusImpl.getTable(CalciteSchema.java:561)
>       at 
> org.apache.flink.table.api.TableEnvironment.scanInternal(TableEnvironment.scala:497)
>       at 
> org.apache.flink.table.api.TableEnvironment.scan(TableEnvironment.scala:485)
>       at Repro$.main(repro.scala:17)
>       at Repro.main(repro.scala)
> {code}
> Dependencies:
> {code}
>     compile 'org.slf4j:slf4j-api:1.7.25'
>     compile 'org.slf4j:slf4j-log4j12:1.7.25'
>     runtime 'log4j:log4j:1.2.17'
>     compile 'org.apache.flink:flink-scala_2.11:1.4.2'
>     compile 'org.apache.flink:flink-streaming-scala_2.11:1.4.2'
>     compile 'org.apache.flink:flink-clients_2.11:1.4.2'
>     compile 'org.apache.flink:flink-table_2.11:1.4.2'
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)