[ 
https://issues.apache.org/jira/browse/FLINK-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631329#comment-14631329
 ] 

Maximilian Michels commented on FLINK-2300:
-------------------------------------------

I see your point. I think the initial idea for introducing the github link tag 
was that the base url for the GitHub links actually changed in the past, e.g. 
when Flink became a fork of Stratosphere or when flink-incubator became flink. 
However, I agree that it is a matter of simply replacing an old base url with a 
new one.

The tag saves us to write {{http://github.com/apache/flink/}} but you're right 
we could also have a variable {{site.github_url}} to abbreviate that. So let's 
get rid of the tag and use a config variable. If you would still like to do 
that, please go ahead. If not, somebody else might want to give it a try.

> Links on FAQ page not rendered correctly
> ----------------------------------------
>
>                 Key: FLINK-2300
>                 URL: https://issues.apache.org/jira/browse/FLINK-2300
>             Project: Flink
>          Issue Type: Bug
>          Components: Project Website
>            Reporter: Robert Metzger
>            Assignee: Maximilian Michels
>            Priority: Minor
>              Labels: starter
>         Attachments: fix_github_plugin.patch
>
>
> On the Flink website, the links using the "github" plugin are broken.
> For example
> {code}
> {% github README.md master "build instructions" %}
> {code}
> renders to
> {code}
> https://github.com/apache/flink/tree/master/README.md
> {code}
> See:
> http://flink.apache.org/faq.html#my-job-fails-early-with-a-javaioeofexception-what-could-be-the-cause
> I was not able to resolve the issue by using {{<a>}} tags or markdown links.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to