[
https://issues.apache.org/jira/browse/FLINK-9229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448013#comment-16448013
]
ASF GitHub Bot commented on FLINK-9229:
---------------------------------------
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/5898
[FLINK-9229] [table] Fix literal handling in code generation
## What is the purpose of the change
This PR fixes wrong usages of `generateNonNullLiteral`. It has been used at
locations where expression are not constant.
## Brief change log
Remove invalid calls to literal methods.
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? JavaDocs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-9229
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5898.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5898
----
commit 1d1217cf8e050baa09c8f93f39efb1b6b4bd68d4
Author: Timo Walther <twalthr@...>
Date: 2018-04-23T11:28:21Z
[FLINK-9229] [table] Fix literal handling in code generation
----
> Fix literal handling in code generation
> ---------------------------------------
>
> Key: FLINK-9229
> URL: https://issues.apache.org/jira/browse/FLINK-9229
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.4.2
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Major
>
> Information about expressions that are constant help during code generation.
> Especially when moving often reused parts of code in the member area of a
> generated function. Right now this behavior is not consistent because even
> methods in {{generateFieldAccess}} generate literals but they are not
> constant. This could lead to unintended behavior.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
