[ 
https://issues.apache.org/jira/browse/FLINK-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449990#comment-16449990
 ] 

ASF GitHub Bot commented on FLINK-9138:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5860#discussion_r183757920
  
    --- Diff: 
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
 ---
    @@ -536,6 +553,9 @@ private void openNewPartFile(Path bucketPath, 
BucketState<T> bucketState) throws
                        partPath = new Path(bucketPath, partPrefix + "-" + 
subtaskIndex + "-" + bucketState.partCounter);
                }
     
    +           // Record the creation time of the bucket
    +           bucketState.firstWrittenToTime = 
processingTimeService.getCurrentProcessingTime();
    --- End diff --
    
    I think the current behavior is also more consistent than starting the 
timeout when the first record is written. 


> Enhance BucketingSink to also flush data by time interval
> ---------------------------------------------------------
>
>                 Key: FLINK-9138
>                 URL: https://issues.apache.org/jira/browse/FLINK-9138
>             Project: Flink
>          Issue Type: Improvement
>          Components: filesystem-connector
>    Affects Versions: 1.4.2
>            Reporter: Narayanan Arunachalam
>            Priority: Major
>
> BucketingSink now supports flushing data to the file system by size limit and 
> by period of inactivity. It will be useful to also flush data by a specified 
> time period. This way, the data will be written out when write throughput is 
> low but there is no significant time period gaps between the writes. This 
> reduces ETA for the data in the file system and should help move the 
> checkpoints faster as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to