[GitHub] flink pull request #5834: [FLINK-9153] TaskManagerRunner should support rpc ...

[zentol]

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5834#discussion_r184029857
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
 ---
    @@ -355,13 +359,53 @@ public static RpcService createRpcService(
                                taskManagerHostname, 
taskManagerAddress.getHostAddress());
                }
     
    -           final int rpcPort = 
configuration.getInteger(ConfigConstants.TASK_MANAGER_IPC_PORT_KEY, 0);
    +           final String portRangeDefinition = 
configuration.getString(TaskManagerOptions.RPC_PORT, "0");
    --- End diff --
    
    don't need the override default as `0` is already the default.


---