[
https://issues.apache.org/jira/browse/FLINK-9153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452108#comment-16452108
]
ASF GitHub Bot commented on FLINK-9153:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5834#discussion_r184029857
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
---
@@ -355,13 +359,53 @@ public static RpcService createRpcService(
taskManagerHostname,
taskManagerAddress.getHostAddress());
}
- final int rpcPort =
configuration.getInteger(ConfigConstants.TASK_MANAGER_IPC_PORT_KEY, 0);
+ final String portRangeDefinition =
configuration.getString(TaskManagerOptions.RPC_PORT, "0");
--- End diff --
don't need the override default as `0` is already the default.
> TaskManagerRunner should support rpc port range
> -----------------------------------------------
>
> Key: FLINK-9153
> URL: https://issues.apache.org/jira/browse/FLINK-9153
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
> Affects Versions: 1.4.0, 1.5.0
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Major
> Fix For: 1.5.0
>
>
> TaskManagerRunner current just support one specific port :
> {code:java}
> final int rpcPort =
> configuration.getInteger(ConfigConstants.TASK_MANAGER_IPC_PORT_KEY, 0);
> {code}
> It should support port range as the document described :
> https://ci.apache.org/projects/flink/flink-docs-master/ops/config.html#taskmanager-rpc-port
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
