[GitHub] flink pull request #5930: [FLINK-9263][state] Fix concurrency problem in Def...

[StefanRRichter]

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5930#discussion_r184708667
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastBackendStateMetaInfo.java
 ---
    @@ -52,6 +52,23 @@ public RegisteredBroadcastBackendStateMetaInfo(
                this.valueSerializer = 
Preconditions.checkNotNull(valueSerializer);
        }
     
    +   public 
RegisteredBroadcastBackendStateMetaInfo(RegisteredBroadcastBackendStateMetaInfo 
copy) {
    +
    +           Preconditions.checkNotNull(copy);
    +
    +           this.name = copy.name;
    +           this.assignmentMode = copy.assignmentMode;
    +           this.keySerializer = copy.keySerializer.duplicate();
    +           this.valueSerializer = copy.valueSerializer.duplicate();
    +   }
    +
    +   /**
    +    * Creates a deep copy of the itself.
    +    */
    +   public RegisteredBroadcastBackendStateMetaInfo deepCopy() {
    --- End diff --
    
    Should not return raw type as well, but 
`RegisteredOperatorBackendStateMetaInfo<S>`.


---