Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5938#discussion_r184848354
  
    --- Diff: flink-yarn/src/test/java/org/apache/flink/yarn/UtilsTest.java ---
    @@ -18,227 +18,35 @@
     
     package org.apache.flink.yarn;
     
    -import org.apache.flink.configuration.Configuration;
    -import org.apache.flink.runtime.akka.AkkaUtils;
    -import 
org.apache.flink.runtime.clusterframework.ContaineredTaskManagerParameters;
    -import 
org.apache.flink.runtime.clusterframework.messages.NotifyResourceStarted;
    -import 
org.apache.flink.runtime.clusterframework.messages.RegisterResourceManager;
    -import 
org.apache.flink.runtime.clusterframework.messages.RegisterResourceManagerSuccessful;
    -import org.apache.flink.runtime.instance.AkkaActorGateway;
    -import 
org.apache.flink.runtime.leaderretrieval.SettableLeaderRetrievalService;
    -import org.apache.flink.runtime.messages.Acknowledge;
    -import org.apache.flink.runtime.testingUtils.TestingUtils;
    -import org.apache.flink.util.TestLogger;
    -import org.apache.flink.yarn.messages.NotifyWhenResourcesRegistered;
    -import org.apache.flink.yarn.messages.RequestNumberOfRegisteredResources;
    -
    -import akka.actor.ActorRef;
    -import akka.actor.ActorSystem;
    -import akka.actor.PoisonPill;
    -import akka.actor.Props;
    -import akka.testkit.JavaTestKit;
    -import org.apache.hadoop.yarn.api.records.ApplicationAttemptId;
    -import org.apache.hadoop.yarn.api.records.ApplicationId;
    -import org.apache.hadoop.yarn.api.records.Container;
    -import org.apache.hadoop.yarn.api.records.ContainerId;
    -import org.apache.hadoop.yarn.api.records.ContainerLaunchContext;
    -import org.apache.hadoop.yarn.api.records.NodeId;
    -import org.apache.hadoop.yarn.client.api.AMRMClient;
    -import org.apache.hadoop.yarn.client.api.NMClient;
    -import org.apache.hadoop.yarn.client.api.async.AMRMClientAsync;
    -import org.apache.hadoop.yarn.conf.YarnConfiguration;
    -import org.junit.AfterClass;
    -import org.junit.BeforeClass;
    +import org.junit.Rule;
     import org.junit.Test;
    -import org.mockito.Matchers;
    -import org.mockito.invocation.InvocationOnMock;
    -import org.mockito.stubbing.Answer;
    +import org.junit.rules.TemporaryFolder;
     
    -import java.util.ArrayList;
    +import java.nio.file.Files;
    +import java.nio.file.Path;
     import java.util.Collections;
    -import java.util.HashMap;
    -import java.util.List;
    -import java.util.UUID;
    -import java.util.concurrent.CompletableFuture;
    -import java.util.concurrent.TimeUnit;
    -
    -import scala.Option;
    -import scala.concurrent.Await;
    -import scala.concurrent.Future;
    -import scala.concurrent.duration.Deadline;
    -import scala.concurrent.duration.FiniteDuration;
     
    -import static org.junit.Assert.assertEquals;
    -import static org.mockito.Mockito.doAnswer;
    -import static org.mockito.Mockito.mock;
    -import static org.mockito.Mockito.when;
    +import static org.hamcrest.Matchers.equalTo;
    +import static org.junit.Assert.assertThat;
     
     /**
      * Tests for {@link Utils}.
      */
    -public class UtilsTest extends TestLogger {
    +public class UtilsTest {
    --- End diff --
    
    `TestLogger` missing.


---

Reply via email to