[GitHub] flink pull request #5940: [FLINK-8690][table]Support group window distinct a...

[suez1224]

Github user suez1224 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5940#discussion_r184866337
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonAggregate.scala
 ---
    @@ -49,11 +49,16 @@ trait CommonAggregate {
     
         val aggs = namedAggregates.map(_.getKey)
         val aggStrings = aggs.map( a => s"${a.getAggregation}(${
    -      if (a.getArgList.size() > 0) {
    +      val prefix = if (a.isDistinct) {
    --- End diff --
    
    I think one line should be fine here, slightly more compact IMO.
    
    val prefix = if (a.isDistinct) "DISTINCT " else ""


---