[ 
https://issues.apache.org/jira/browse/FLINK-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634756#comment-14634756
 ] 

ASF GitHub Bot commented on FLINK-2371:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/925#discussion_r35079360
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorLiveITCase.java
 ---
    @@ -109,125 +123,157 @@ public void testProgram() throws Exception {
                        ExecutionEnvironment env = new PlanExtractor();
                        DataSet<String> input = env.fromCollection(inputData);
                        input
    -                                   .flatMap(new Tokenizer())
                                        .flatMap(new WaitingUDF())
                                        .output(new WaitingOutputFormat());
                        env.execute();
     
    -                   /** Extract job graph **/
    +                   // Extract job graph and set job id for the task to 
notify of accumulator changes.
                        JobGraph jobGraph = getOptimizedPlan(((PlanExtractor) 
env).plan);
    +                   jobID = jobGraph.getJobID();
    +
    +                   // register for accumulator changes
    +                   jobManager.tell(new 
TestingJobManagerMessages.NotifyWhenAccumulatorChange(jobID), getRef());
    +                   expectMsgEquals(true);
     
    +                   // submit job
                        jobManager.tell(new 
JobManagerMessages.SubmitJob(jobGraph, false), getRef());
                        expectMsgClass(Status.Success.class);
    --- End diff --
    
    Same here. Best if you nest all actor interaction in a `within` block.


> AccumulatorLiveITCase fails
> ---------------------------
>
>                 Key: FLINK-2371
>                 URL: https://issues.apache.org/jira/browse/FLINK-2371
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Matthias J. Sax
>            Assignee: Maximilian Michels
>
> AccumulatorLiveITCase fails regularly (however, not in each run). The tests 
> relies on timing (via sleep) which does not work well on Travis.
> See dev-list for more details: 
> https://mail-archives.apache.org/mod_mbox/flink-dev/201507.mbox/browser
> AccumulatorLiveITCase.testProgram:106->access$1100:68->checkFlinkAccumulators:189



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to