Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/925#discussion_r35086920
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala
---
@@ -51,10 +51,13 @@ import scala.concurrent.{ExecutionContext, Future,
Await}
abstract class FlinkMiniCluster(
val userConfiguration: Configuration,
val singleActorSystem: Boolean,
+ val synchronousDispatcher: Boolean,
val streamingMode: StreamingMode) {
- def this(userConfiguration: Configuration, singleActorSystem: Boolean)
- = this(userConfiguration, singleActorSystem,
StreamingMode.BATCH_ONLY)
+ def this(userConfiguration: Configuration,
+ singleActorSystem: Boolean,
+ synchronousDispatcher: Boolean)
+ = this(userConfiguration, singleActorSystem, synchronousDispatcher,
StreamingMode.BATCH_ONLY)
--- End diff --
I think the field `synchronousDispatcher` should not be part of the
`FlinkMiniCluster`. The field seems to be only used for testing, referenced in
`TestingCluster`, but the `FlinkMiniCluster` is also used to execute Flink
programs locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
