[ 
https://issues.apache.org/jira/browse/FLINK-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462126#comment-16462126
 ] 

ASF GitHub Bot commented on FLINK-9286:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5948#discussion_r185731303
  
    --- Diff: docs/monitoring/debugging_classloading.md ---
    @@ -69,9 +69,9 @@ cases. By default, Java ClassLoaders will first look for 
classes in the parent C
     the child ClassLoader for cases where we have a hierarchy of ClassLoaders. 
This is problematic if you
     have in your user jar a version of a library that conflicts with a version 
that comes with Flink. You can
     change this behaviour by configuring the ClassLoader resolution order via
    -`classloader.resolve-order: child-first` in the Flink config. However, 
Flink classes will still
    +[classloader.resolve-order](../ops/config.html#classloader-resolve-order) 
in the Flink config. However, Flink classes will still
     be resolved through the parent ClassLoader first, although you can also 
configure this via
    -`classloader.parent-first-patterns` (see [config](../ops/config.html))
    
+[classloader.parent-first-patterns-default](../ops/config.html#classloader-parent-first-patterns-default).
    --- End diff --
    
    How about referencing `classloader.parent-first-patterns-additional here 
instead? The recommendation is not to change the value for "default"...


> Update classloading debugging page
> ----------------------------------
>
>                 Key: FLINK-9286
>                 URL: https://issues.apache.org/jira/browse/FLINK-9286
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> The [classloading 
> debugging|https://ci.apache.org/projects/flink/flink-docs-master/monitoring/debugging_classloading.html#configuring-classloader-resolution-order]
>  page must be updated for 1.5.
> The [parent-first pattern 
> section|https://ci.apache.org/projects/flink/flink-docs-master/monitoring/debugging_classloading.html#configuring-classloader-resolution-order]
>  refers to deprecated keys.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to