[
https://issues.apache.org/jira/browse/FLINK-9287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462480#comment-16462480
]
ASF GitHub Bot commented on FLINK-9287:
---------------------------------------
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/5952
[FLINK-9287][kafka] Properly clean up resources in non EXACTLY_ONCE
FlinkKafkaProducer011
Previously FlinkKafkaProducer was not being closed for AT_LEAST_ONCE and
NONE Semantics when closing FlinkKafkaProducer011. This was leading to
resources leaking (for example increasing number of active threads).
## Verifying this change
This bug fix might be hard to test automatically. This PR adds a new test
proposal in separate commit, however it might be flaky if there are other tests
being executed in parallel.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pnowojski/flink f9287
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5952.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5952
----
commit c9139a90dd6a2afb25a4eb3102e1abedf90d8f5f
Author: Piotr Nowojski <piotr.nowojski@...>
Date: 2018-05-03T13:50:53Z
[FLINK-9287][kafka] Properly clean up resources in non EXACTLY_ONCE
FlinkKafkaProducer011
Previously FlinkKafkaProducer was not being closed for AT_LEAST_ONCE and
NONE Semantics
when closing FlinkKafkaProducer011. This was leading to resources leaking
(for example
increasing number of active threads)
commit 5a1d0962f3fb92a87ee809b5a09106f5c4d05caf
Author: Piotr Nowojski <piotr.nowojski@...>
Date: 2018-05-03T13:53:40Z
[FLINK-9287][kafka] Ensure threads count do not grow in
FlinkKafkaProducer011
----
> KafkaProducer011 seems to leak threads when not in exactly-once mode
> --------------------------------------------------------------------
>
> Key: FLINK-9287
> URL: https://issues.apache.org/jira/browse/FLINK-9287
> Project: Flink
> Issue Type: Bug
> Components: Kafka Connector
> Affects Versions: 1.5.0, 1.4.2
> Reporter: Christopher Ng
> Priority: Blocker
> Fix For: 1.5.0
>
>
> {{KafkaProducer011}} appears to be leaking {{kafka-producer-network-thread}}
> threads. As far as I can tell it happens when it is not in EXACTLY_ONCE
> mode, it seems that it creates a {{FlinkKafkaProducer}} but never closes it,
> even when the {{FlinkKafkaProducer011}} itself is closed.
> I observed this when running a local cluster and submitting and then
> cancelling a job, a lot of kafka threads were left alive afterwards.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
