GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/5961
[Flink-8255][DataSet API, DataStream API] key expressions on named row
types do not work
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best possible way, please go through the checklist below,
which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a
hassle. In order to uphold a high standard of quality for code contributions,
while at the same time managing a large number of contributions, we need
contributors to prepare the contributions well, and give reviewers enough
contextual information for the review. Please also understand that
contributions that do not follow this guide will take longer to review and thus
typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are
made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of
the pull request", where *FLINK-XXXX* should be replaced by the actual issue
number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes. You can set up Travis CI to do that following [this
guide](http://flink.apache.org/contribute-code.html#best-practices).
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
(including the JIRA id)
- Once all items of the checklist are addressed, remove the above text
and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
## What is the purpose of the change
Fix issues related to ClassCastExceptions from Flink-8255 + add more tests
## Brief change log
- Usage of casting to TupleTypeInfoBase rather than to TupleTypeInfo as
RowTypeInfo is a child of TupleTypeInfoBase but in a different branch in
compare with TupleTypeInfo
- Add more tests which will fail with ClassCastException without changes
from the previous item
## Verifying this change
*(Please pick either of the following options)*
This change added tests and can be verified as follows:
- Added tests that validates that ClassCastException related to Flink-8255
are not happen
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes)
- The serializers: (don't know)
- The runtime per-record code paths (performance sensitive): (don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/snuyanzin/flink
FLINK-8255_Key_expressions_on_named_row_types_do_not_work
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5961.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5961
----
commit 50eb4ead75ddc22e0eee2bf5a2b9d12c37dcaeb4
Author: snuyanzin <snuyanzin@...>
Date: 2018-04-29T18:37:05Z
FLINK-8255 Key expressions on named row types do not work
Test case from description + 2 more
Resolution of class cast by using of TupleTypeInfoBase rather than
TupleTypeInfo
commit 96d569025e21172059bb5b34cf93f3a60b5f0a0e
Author: snuyanzin <snuyanzin@...>
Date: 2018-04-29T18:47:52Z
FLINK-8255 Key expressions on named row types do not work
Test case from description + 2 more
Resolution of class cast by using of TupleTypeInfoBase rather than
TupleTypeInfo
commit 889f226b2268e5e23ed3de672a60a05702c111aa
Author: snuyanzin <snuyanzin@...>
Date: 2018-04-29T20:30:04Z
FLINK-8255 Key expressions on named row types do not work
Test case from description + 2 more
Resolution of class cast by using of TupleTypeInfoBase rather than
TupleTypeInfo
commit 93dd630dd5a833a0e343a5ff53d0c5e5f37934cd
Author: snuyanzin <snuyanzin@...>
Date: 2018-05-07T05:13:14Z
FLINK-8255 Key expressions on named row types do not work
Test case from description + 2 more
Resolution of class cast by using of TupleTypeInfoBase rather than
TupleTypeInfo
commit dc20cca498c2758d1cc0fa87bc51461a564e41f7
Author: snuyanzin <snuyanzin@...>
Date: 2018-05-07T05:40:10Z
FLINK-8255 Key expressions on named row types do not work
Test case from description + 2 more
Resolution of class cast by using of TupleTypeInfoBase rather than
TupleTypeInfo
commit b1f33282c30cbc6ee7b9d6e3b595fc03955346b0
Author: snuyanzin <snuyanzin@...>
Date: 2018-05-07T05:45:04Z
FLINK-8255 Key expressions on named row types do not work
Test case from description + 2 more
Resolution of class cast by using of TupleTypeInfoBase rather than
TupleTypeInfo
commit 295d0fc719010783da591781e9c4ab60e3e216e4
Author: snuyanzin <snuyanzin@...>
Date: 2018-05-07T08:15:12Z
FLINK-8255 Key expressions on named row types do not work
Test case from description + 2 more
Resolution of class cast by using of TupleTypeInfoBase rather than
TupleTypeInfo
----
---
